Schrottkatze schrottkatze
schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-21 19:25:27 +00:00
feat: Graph IR

Is this the note that was referred to in the other file? Or the one inside the struct?

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-21 19:25:27 +00:00
feat: Graph IR

i mean yes, maybe slap one (or two) TODO comments there?

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-21 19:25:27 +00:00
feat: Graph IR

see note in Evaluator trait above this method

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-21 19:25:27 +00:00
feat: Graph IR

wdym?

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-21 19:25:27 +00:00
feat: Graph IR

I'm going to rework this to be much more statically typed, but for now this should be fine.

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-21 19:25:27 +00:00
feat: Graph IR

note to keep in mind for later, maybe this should also have the option to have default values? probably rather relevant for frontends...

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-21 19:25:27 +00:00
feat: Graph IR

potentially clarify that that's just for us, the devs, debugging?

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-21 19:25:27 +00:00
feat: Graph IR

I generally prefer using to_owned, since it's more clear that you're turning an unowned string (&str) into an owned String.

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-21 19:25:27 +00:00
feat: Graph IR

One general note (mostly for later, which I'll work on in the next few days): The runtime should be able to mix and match executors, so one executor may not fully support all instructions but for that offer more performance (because some shit might be harder to implement as compute shaders) so switching on the fly is possible.

schrottkatze created repository schrottkatze/iowo 2024-01-20 19:28:29 +00:00
schrottkatze closed pull request katzen-cafe/iowo#3 2024-01-20 19:26:34 +00:00
design: type system design
schrottkatze commented on pull request katzen-cafe/iowo#3 2024-01-20 19:26:34 +00:00
design: type system design

Closing because I fucked up the git setup here and locally.

schrottkatze pushed to main at katzen-cafe/iowo 2024-01-20 19:09:54 +00:00
48458fd1c9 remove old cli
746c81ab60 app(cli): apply review
0615ea653c app(doc): well... write the docs
6006f92d9c app: better? config error handling
7c9dca0ae2 app: improve config loading and merging
Compare 12 commits »
schrottkatze merged pull request katzen-cafe/iowo#7 2024-01-20 19:09:52 +00:00
start working on a cli app
schrottkatze approved katzen-cafe/iowo#2 2024-01-20 18:56:58 +00:00
docs: some initial groundwork

I think this is ready to merge then!

schrottkatze commented on pull request katzen-cafe/iowo#7 2024-01-20 18:06:58 +00:00
start working on a cli app

I think this one also depends on #2, so lets get that finally merged first :)

schrottkatze commented on pull request katzen-cafe/iowo#2 2024-01-20 18:00:28 +00:00
docs: some initial groundwork

that reads a bit weird to me, maybe rephrase to:

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-20 16:47:27 +00:00
feat: Graph IR

ahh I see!

schrottkatze commented on pull request katzen-cafe/iowo#2 2024-01-20 15:55:09 +00:00
docs: some initial groundwork

The highlighted "you're* feels a bit, maybe split it into "you are" and highlight the "you"? (small nitpicky wording thing lol)

schrottkatze suggested changes for katzen-cafe/iowo#2 2024-01-20 15:55:09 +00:00
docs: some initial groundwork