katzen-cafe/iowo
2
4
Fork 1
Code Issues 4 Pull requests 2 Projects Releases Packages Wiki Activity

design: type system design #3

Closed
schrottkatze wants to merge 2 commits from (deleted):main into main
pull from: (deleted):main
merge into: katzen-cafe:main
Conversation 7 Commits 2 Files changed 1 +36 -3
schrottkatze commented 2024-01-08 12:45:54 +00:00
Owner
Copy link

In the new documents there my suggestions and ideas for a type system. not final or anything, just ideas.

In the new documents there my suggestions and ideas for a type system. not final or anything, just ideas.
schrottkatze added 2 commits 2024-01-08 12:45:54 +00:00
multisamplednight reviewed 2024-01-10 22:49:25 +00:00
docs/design/types.typ
@ -11,0 +38,4 @@
`[[(u8, u8, u8)]] * f32 -> [[(u8, u8, u8)]]`
Since all of the values are numbers (-> implementing `Num`/`Number`), they should be able to implicitely multiplied.
multisamplednight commented 2024-01-10 22:49:25 +00:00
Collaborator
Copy link

Typo.

-Since all of the values are numbers (-> implementing `Num`/`Number`), they should be able to implicitely multiplied. 
+Since all of the values are numbers (-> implementing `Num`/`Number`), they should be able to implicitly multiplied.
Typo. ```diff -Since all of the values are numbers (-> implementing `Num`/`Number`), they should be able to implicitely multiplied. +Since all of the values are numbers (-> implementing `Num`/`Number`), they should be able to implicitly multiplied. ```
multisamplednight reviewed 2024-01-10 22:50:00 +00:00
docs/design/types.typ
@ -11,0 +20,4 @@
=== Generic-focused
Color-awareness may be handled as seperate types, so one might have `LinearRgb`, `SRgb`, `Xyz` etc. Optimally implemented using our own constructs.
multisamplednight commented 2024-01-10 22:50:00 +00:00
Collaborator
Copy link

Why not use the palette crate instead?

Why not use the `palette` crate instead?
schrottkatze commented 2024-01-11 15:11:18 +00:00
Author
Owner
Copy link

I meant in-language constructs, but that's probably something to put on the far future todo list...

I'm concerned about lacking support for OCIO, but realistically, throw that on that list too lol

I meant in-language constructs, but that's probably something to put on the far future todo list... I'm concerned about lacking support for [OCIO](https://opencolorio.org/), but realistically, throw that on that list too lol
schrottkatze commented 2024-01-11 15:13:25 +00:00
Author
Owner
Copy link

Can I change which branch I'm merging from? bc I fucked up and worked on main, resolved that locally now but this pr still tries to merge main

Can I change which branch I'm merging from? bc I fucked up and worked on main, resolved that locally now but this pr still tries to merge main
multisamplednight commented 2024-01-12 15:09:37 +00:00
Collaborator
Copy link

Yeah, after pushing the branch to your fork, you can use the Edit button at the top of this page to make the PR source and target configurable.

Yeah, after pushing the branch to your fork, you can use the `Edit` button at the top of this page to make the PR source and target configurable.
schrottkatze commented 2024-01-12 19:58:07 +00:00
Author
Owner
Copy link

I apparently can't switch the source :/

I apparently can't switch the source :/
multisamplednight commented 2024-01-20 19:19:08 +00:00
Collaborator
Copy link

(pong)

(pong)
schrottkatze commented 2024-01-20 19:26:34 +00:00
Author
Owner
Copy link

Closing because I fucked up the git setup here and locally.

Closing because I fucked up the git setup here and locally.
schrottkatze closed this pull request 2024-01-20 19:26:34 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
proposal

New suggestions that need unanimous consensus.

No labels
proposal
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: katzen-cafe/iowo#3
No description provided.
Delete branch "(deleted):main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?