Ok seriously we probably need to have a meeting and talk about the terminology
Anytime.
this is really becoming a headache and a mess
Assumed somewhere behind this statement is a…
I plan to get rid of this as soon as we have a meaningful source
→ ir
pipeline, actually.
Could you possibly give an example where a default value on an instruction would be desirable?
I'm going to rework this to be much more statically typed, but for now this should be fine.
Sure, however you plan on implementing that.
Probably also the values/data should be able to…
There will necessarily be more variants added to Variant
later on, so the lint is suppressed since it'll be necessary then. The comment refers to this circumstance, not to the output methods…
No. It is referring to the Evaluator
trait at crates/eval/src/lib.rs:9
and to the comment on line 12f.
Done. The eval impl is hacky, but it works for a quick demo of how to use the graph IR.
Chances are you'll want to git remote update; git rebase main
after #2 is merged
The "node" is the instruction, and my idea was that a socketidx might contain a reference to the instruction it belongs to so it's easy to reference to it and hard to fuck up
That is already…
In 666b4f9cb6
I re-ordered the wording a bit, in order to make clear that this is only a suggestion. Is that fine?
AGPL is lovely!
Is that explicit agreement that you're okay with both the CC BY-SA 4.0 and the AGPL?
Maybe also add a pointer to the node each time? Or do you think that'd have a…