katzen-cafe/iowo
2
4
Fork 1
Code Issues 4 Pull requests 2 Projects Releases Packages Wiki Activity

write initial type signature notation proposal #5

Merged
schrottkatze merged 3 commits from :type-notation into main 2024-01-11 14:55:57 +00:00
Conversation 1 Commits 3 Files changed 1 +38
schrottkatze commented 2024-01-10 11:46:19 +00:00
Owner
Copy link

this is just an initial proposal

this is just an initial proposal
multisamplednight was assigned by schrottkatze 2024-01-10 11:46:19 +00:00
schrottkatze added 1 commit 2024-01-10 11:46:19 +00:00
multisamplednight was unassigned by schrottkatze 2024-01-10 11:46:39 +00:00
schrottkatze requested review from multisamplednight 2024-01-10 11:46:45 +00:00
multisamplednight reviewed 2024-01-10 21:05:06 +00:00
docs/design/type-notation.typ
@ -0,0 +1,23 @@
#import "../template.typ": conf
#show: doc => conf(
doc
)
multisamplednight commented 2024-01-10 21:05:06 +00:00
Collaborator
Copy link

Can be simplified.

-#show doc => conf(
-    doc
-)
+#show: conf
Can be simplified. ```diff -#show doc => conf( - doc -) +#show: conf ```
multisamplednight commented 2024-01-10 21:06:33 +00:00
Collaborator
Copy link

Also I suggest adding a title and subtitle once #2 is merged.

Also I suggest adding a title and subtitle once https://forge.katzen.cafe/katzen-cafe/iowo/pulls/2 is merged.
multisamplednight marked this conversation as resolved
multisamplednight reviewed 2024-01-10 21:07:24 +00:00
docs/design/type-notation.typ Outdated
@ -0,0 +6,4 @@
= Type/signature notation
Operator signature that takes two unnamed arbitrary numbers of the same type and returns another:
`Op<T: Num> [ T T ] -> T`
multisamplednight commented 2024-01-10 21:07:24 +00:00
Collaborator
Copy link

Should be full codeblocks.

-`Op<T: Num> [ T T ] -> T`
+```iowo
+Op<T: Num> [ T T ] -> T
+```
Should be full codeblocks. ```diff -`Op<T: Num> [ T T ] -> T` +```iowo +Op<T: Num> [ T T ] -> T +``` ```
multisamplednight requested changes 2024-01-10 21:08:56 +00:00
multisamplednight left a comment
Collaborator
Copy link

How would one write type signatures with multiple generic arguments?

Otherwise, LGTM.

How would one write type signatures with multiple generic arguments? Otherwise, LGTM.
schrottkatze added 2 commits 2024-01-11 09:55:43 +00:00
schrottkatze commented 2024-01-11 09:58:25 +00:00
Author
Owner
Copy link

added the requested example!

added the requested example!
multisamplednight approved these changes 2024-01-11 13:06:24 +00:00
multisamplednight left a comment
Collaborator
Copy link

LGTM! 🎉

LGTM! 🎉
schrottkatze merged commit 70256a7bfc into main 2024-01-11 14:55:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
multisamplednight
Labels
Clear labels   
proposal

New suggestions that need unanimous consensus.

No labels
proposal
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: katzen-cafe/iowo#5
No description provided.
Delete branch ":type-notation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?