Schrottkatze schrottkatze
schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 17:40:06 +00:00
feat: Graph IR

AGPL is lovely!

Maybe also add a pointer to the node each time? Or do you think that'd have a significant performance impact or something?

schrottkatze commented on pull request katzen-cafe/iowo#2 2024-01-19 11:58:03 +00:00
docs: some initial groundwork

I'd just remove the tool-list. Since it's just suggestions anyway. Or at least remove programs like inkscape, of which we won't have in-house custom files in the project. Yes, Ik that inkscape…

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 11:56:20 +00:00
feat: Graph IR

CC-BY-SA.

Not that I care much about it, but yeah.

Once the project progresses, I'll maybe bother rendering it with a lot more data (normals, cryptomatte, whatever) for debugging/example…

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 11:54:14 +00:00
feat: Graph IR

Idk, I just think that that might be useful for hand-written IR (which, don't get me wrong, is not the indended use case obviously. But that might make it a lot easier to debug more complex stuff…

schrottkatze commented on pull request katzen-cafe/iowo#2 2024-01-19 11:50:01 +00:00
docs: some initial groundwork

Okay. Probably will have to write it again if we publisize the project then some day, but until then we have more then enough time

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 11:48:30 +00:00
feat: Graph IR

Do you mean returning the ID of the place it failed and potentially more information (depending on the errors, edges, other ids...)?

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 11:46:08 +00:00
feat: Graph IR

These random rails for now? I know the license situation because well... I made it myself. Probably isn't optimal either, though.

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 11:33:41 +00:00
feat: Graph IR

Namespacing can also just be an ID.

But I take back that library loading may be in the IR, since that makes distribution as binaries possible.

I misunderstood how your implementation works…

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 11:30:32 +00:00
feat: Graph IR

How would you want to report warnings/errors back from the executor then? Do you want the frontend to be responsible for keeping track of a potential ID → span mapping, even though after the…

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 11:23:44 +00:00
feat: Graph IR

not instructions, the metadata field

which may contain spans, typed information etc to generate good errors.

else we'll just be yet another program with useless runtime errors, and that's…

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 11:22:30 +00:00
feat: Graph IR

Why is it?

I think this discussion doesn't belong in a code review, probably in #4.

  • What one value would you want for referring to both a specific instruction and differentiating the…
schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 11:19:45 +00:00
feat: Graph IR

If i understand your implementation correctly, would it theoretically be possible to also allow named instructions then for usability reasons? even if they just get abstracted away (and the name…

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 11:18:28 +00:00
feat: Graph IR

that doesn't solve namespacing for said functions. and imports (which will be necessary in the future anyway), so multiple GraphIrs will be necessary to load "libraries", however those may…

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 10:46:25 +00:00
feat: Graph IR

How do you intend to implement custom function calls then? Rough outline because currently I don't think I understand

gotos kinda or...?

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 10:44:29 +00:00
feat: Graph IR

Ahhh, I see.

I do think that there should only be at most one value because that might make some stuff a lot more elegant, but that's also solvable via syntactic sugar probably (and this is…

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 10:42:38 +00:00
feat: Graph IR

the implementor of the ir (the frontends), since for example the language implementation would just call the runtime and then as a response either get a result or if it fails errors (including…

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 10:37:16 +00:00
feat: Graph IR

i dont think a span (debug info imho) doubling as an id is a good idea i think that should be seperate, so it doesn't get cursed to work with for other implementations that aren't text-based?

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 08:38:29 +00:00
feat: Graph IR

Should later probably more of a graceful exit...

schrottkatze approved katzen-cafe/iowo#6 2024-01-19 08:38:29 +00:00
feat: Graph IR

Also, since I have no idea if I even can review an image: do you know the licensing situation? Maybe use something that's CC-* for sure or that we've created instead?

schrottkatze commented on pull request katzen-cafe/iowo#6 2024-01-19 08:38:29 +00:00
feat: Graph IR

a map of numbers to instructions could also just be a vector?