@schrottkatze The latest commit included the new license, both of the image and the code as a whole. Are you okay with that license?
I still haven't quite understood how the suggestions are bad.
- As long as no creative work is done, I don't see how it could cause potential harm.
- It does not restrict entities from using…
I'd rather avoid the work on introducing metadata fields which Instruction would be generic over, since
- they introduce quite some noise,
- would require a lot of bounds and
- introduce…
Yeah, exactly. The frontend could then just GraphIr::resolve if they want more information about the instruction that failed. Or use the ID to look up in their separate map built at source…
Yeah, then I don't see how metadata is useful for the hand-written IR.
The named instruction thing is something worth to discuss though, imo. Tbh, a lot of the time I'd have difficulties…
Exactly. We'd need it to write again later on, and it'll likely contain very similar content. So why not keep the current version, even if it contains content that is not strictly necessary yet?…
Yes, that would be possible. The semi_human::GraphIr could use string interning for generating IDs then.
I'm not sure if or how per-instruction metadata would be useful here, since some kind…
Hm. I'm not sure if the metadata is worth polluting GraphIr with generics everywhere.
Different suggestion then: How about being transparent about id::Instructions, and allowing the…
I'd argue the concept of "namespaces" or even function names doesn't belong into an executor or into the graph IR, but rather into the frontend.
Why are multiple GraphIrs necessary to load…
Actually, if it's overkill for now, then I'll just remove the whole file as well. Guess we can answer the questions manually instead.
I don't really see the harm the list could do, even if parts of it aren't used yet, but sure, whatever. I'll remove the list.
Through
- #[arg(long, env = "NO_STARTUP_MESSAGE", default_value = "false")]
+ #[arg(long, env = "NO_STARTUP_MESSAGE", action = ArgAction::SetTrue, value_parser = BoolishValuePar…
image licensing situation
No, I do not know the license of the juan meme image. I'd be happy for any alternative suggestions you might have though!
Edges to a different part of the graph. One could think of edges as being kind of gotos.
- How would you want to report warnings/errors back from the executor then? Do you want the frontend to be responsible for keeping track of a potential ID → span mapping, even though after the…
i dont think a span (debug info imho) doubling as an id is a good idea
- Why not?
so it doesn't get cursed to work with for other implementations that aren't text-based?
- As it's…
Not sure if I understand. When would instructions ever be given back to the frontend?