multisn8 multisamplednight
  • wherever cute entities are
  • i need E

  • Joined on 2024-01-01
multisamplednight commented on pull request katzen-cafe/iowo#12 2024-02-22 17:53:22 +00:00
WIP: image processing library (or libraries?)

Given the common pattern of AsRef in the stdlib and InstructionRef already being used in this project, how about renaming OwnedData → Data and Data below → DataRef?

multisamplednight commented on pull request katzen-cafe/iowo#12 2024-02-22 17:53:22 +00:00
WIP: image processing library (or libraries?)

Quite ambiguous doc-comment also regarding the rather lengthy doc-comment on the type itself.

multisamplednight commented on pull request katzen-cafe/iowo#12 2024-02-22 17:53:22 +00:00
WIP: image processing library (or libraries?)

All of these dev commands seem like they'd belong into tests using #[test] instead.

multisamplednight commented on pull request katzen-cafe/iowo#12 2024-02-22 17:53:22 +00:00
WIP: image processing library (or libraries?)

Why do Add, Subtract, Concatenate hold a pub i32 if it's never used?

multisamplednight commented on pull request katzen-cafe/iowo#12 2024-02-22 17:53:22 +00:00
WIP: image processing library (or libraries?)

Could use Option::ok_or with Result::or_else (untested):

multisamplednight commented on pull request katzen-cafe/iowo#12 2024-02-22 17:53:22 +00:00
WIP: image processing library (or libraries?)

Given that you use a module comment at the very start of this file, it seems like these doc-comments would also belong into their respective modules.

multisamplednight commented on pull request katzen-cafe/iowo#12 2024-02-22 17:53:22 +00:00
WIP: image processing library (or libraries?)

Wait, why is Outputs allowed to be consumed for its inner content consumed while Inputs doesn't?

multisamplednight commented on pull request katzen-cafe/iowo#12 2024-02-22 17:53:22 +00:00
WIP: image processing library (or libraries?)

Nit: Regarding formatting, you may want to split the newly added entry to its own line.

multisamplednight commented on pull request katzen-cafe/iowo#12 2024-02-22 17:53:22 +00:00
WIP: image processing library (or libraries?)

Also regarding the enum-based arch: Why the indirection of fn(&Inputs) -> Outputs? Why does Pipeline not hold Box<dyn Element> as well?

multisamplednight commented on pull request katzen-cafe/iowo#12 2024-02-22 17:53:22 +00:00
WIP: image processing library (or libraries?)

Could use an intralink.

multisamplednight commented on pull request katzen-cafe/iowo#12 2024-02-22 17:53:22 +00:00
WIP: image processing library (or libraries?)

Those TODO:s seem like they should belong in an issue, so one can

multisamplednight commented on pull request katzen-cafe/iowo#6 2024-01-22 09:55:41 +00:00
feat: Graph IR

I've decided I do not want to contribute to iOwO anymore, due to lack of general cooperativity and @schrottkatze not willing to discuss things such as using vulkano that are, apparently, set in…

multisamplednight closed pull request katzen-cafe/iowo#6 2024-01-22 09:41:50 +00:00
feat: Graph IR
multisamplednight commented on issue katzen-cafe/iowo#9 2024-01-22 09:27:12 +00:00
general/planning: some ramblings and plans on what to do how when

Since you want to do the first one in a mega-PR, I'll focus on IR handling and source in meantime.

multisamplednight commented on pull request katzen-cafe/iowo#6 2024-01-22 09:14:57 +00:00
feat: Graph IR

And I'd say that we specify a Streamer as a function that generates output without any input, and add a "sink" as a function that just takes in inputs and is effectively the end of a given…

multisamplednight commented on pull request katzen-cafe/iowo#6 2024-01-22 09:08:23 +00:00
feat: Graph IR

I want ir::GraphIr to be the single source of truth regarding the IR, and not a programmatic in-between that is kinda-for-human-interaction-but-not-really that breaks type safety.

For…

multisamplednight commented on pull request katzen-cafe/iowo#6 2024-01-22 09:05:02 +00:00
feat: Graph IR

Named args are implied by #4.

multisamplednight commented on pull request katzen-cafe/iowo#6 2024-01-21 21:14:07 +00:00
feat: Graph IR

Did that in 63d7993940 on page 2. Could you possibly look over it?

multisamplednight commented on pull request katzen-cafe/iowo#6 2024-01-21 20:31:26 +00:00
feat: Graph IR

I'll just do that, actually.

multisamplednight commented on pull request katzen-cafe/iowo#6 2024-01-21 20:27:50 +00:00
feat: Graph IR

Actually, if it causes this much confusion, I'll just remove the comment here to make the other one the single source of truth.