yes, but I don't think that's avoidable.
It is. One could clone the vec on every instruction call.
i have an idea what one could do for that, I'll be implementing that soon-ish when i have the energy
Does this idea imply a map of fn pointer to debug info? If so, I'm not sure if the size…
Non-content-related: I very much appreciate you experimenting around with possible architectures! It's most likely very tiring, but still very important for a nice API.
At this point I think the trait architecture is superior in extensibility, scalability and just by how much simpler and more readable it is.
I'll try to make the data types trait based as…
They do save 1 indirection, but that is 1 indirection which hasn't even been benchmarked yet against
- worse debuggability
- when
DebuggingPipelineif it were to implementDebug, all…
- when
Also, that just addresses one point, while the other 3 are still standing.
So you'd rather do all the work of finding all TODO:s and converting them to issues (and then creating a PR removing them) after "finishing" prowocessing?
sure, can do that, but i much prefer having them run like that and output there so i can see it more or less interactively.
They're still just as interactive if one were to use `cargo test…
Then how about cloning it instead?
let config = args.config_path.clone().ok_or(()).or_else(Both ops::num and ops::str could very much use the guard condition pattern with let-else instead, so that the actual intended logic of the runner function isn't nested one more.
Unnecessary full method path, consider just using From::from or Into::into instead.
Why does OwnedData implement Debug while Data doesn't?
Given that you use a module comment at the very start of this file, it seems like these doc-comments would also belong into their respective modules.
I already see that this is a newtype around OwnedData, just re-stating it does not add semantical value. Rather, what would this struct be used for?
Consider implementing [ToOwned] and [AsRef] appropiately instead.
The condition might be more visible if it's put in an explicit # Indirect panics section or the like.