katzen-cafe/iowo
2
4
Fork 1
Code Issues 4 Pull requests 2 Projects Releases Packages Wiki Activity

WIP: image processing library (or libraries?) #12

Draft
schrottkatze wants to merge 15 commits from schrottkatze/iowo:proc-libs into main
pull from: schrottkatze/iowo:proc-libs
merge into: katzen-cafe:main
Conversation 3 Commits 15 Files changed 20 +10 -5
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 6d318aa7c9 - Show all commits

15
crates/app/src/config.rs
View file

@ -14,11 +14,16 @@ pub struct Config {
impl Config {
/// Get the configs from all possible places (args, file, env...)
pub fn read(args: &CliConfigs) -> Self {
let config = if let Some(config) = &args.config_path {
Ok(config.clone())
} else {
find_config_file()
};
// let config = if let Some(config) = &args.config_path {
schrottkatze marked this conversation as resolved Outdated
multisamplednight commented 2024-02-22 17:24:33 +00:00
Outdated
Review
Copy link

Could use Option::ok_or with Result::or_else (untested):

let config = args.config_path.as_ref().ok_or(()).or_else(|_| find_config_file());
Could use `Option::ok_or` with `Result::or_else` (untested): ```rust let config = args.config_path.as_ref().ok_or(()).or_else(|_| find_config_file()); ```
schrottkatze commented 2024-02-23 09:29:49 +00:00
Outdated
Review
Copy link

Doesn't work since find_config_file returns an owned value and the other value is unowned, if i add .as_ref() to the find_config_file call, it doesn't work either since then it's a temporary value.

Doesn't work since `find_config_file` returns an owned value and the other value is unowned, if i add `.as_ref()` to the `find_config_file` call, it doesn't work either since then it's a temporary value.
multisamplednight commented 2024-02-23 14:17:46 +00:00
Outdated
Review
Copy link

Then how about cloning it instead?

let config = args.config_path.clone().ok_or(()).or_else(|_| find_config_file());
Then how about cloning it instead? ```rust let config = args.config_path.clone().ok_or(()).or_else(|_| find_config_file()); ```
schrottkatze commented 2024-02-27 12:18:42 +00:00
Outdated
Review
Copy link

Works.

Works.
// Ok(config.clone())
// } else {
// find_config_file()
// };
let config = args
.config_path
.clone()
.ok_or(())
.or_else(|()| find_config_file());
// try to read a maybe existing config file
let config = config.ok().and_then(|path| {